Add Chinese Translation

[Bill-Haku]

translation includes:

• artifacts.json5
• enemies.json5
• some of characters.json5

[CLAassistant]

All committers have signed the CLA.

[xicri]

Thanks, LGTM!
When I have fixed tests and CI, I will notify you.

[xicri]

@Bill-Haku Oh, GitHub Actions pointed out that you use “ and ” instead of ". Can you fix it?

[Bill-Haku]

@Bill-Haku Oh, GitHub Actions pointed out that you use “ and ” instead of ". Can you fix it?

I'm sorry for that, I will check it soon.

[xicri]

@Bill-Haku No problem, since I need time for fixing tests & CI, you don't have to hurry.

[Bill-Haku]

It is fixed and LICENSE has been translated.

[Bill-Haku]

% npm run build

> build
> node scripts/build.js

file:///Users/hakubill/genshin-langdata/node_modules/node-fetch/src/index.js:108
                        reject(new FetchError(`request to ${request.url} failed, reason: ${error.message}`, 'system', error));
                               ^

FetchError: request to https://dataset.genshin-dictionary.com/words.json failed, reason: getaddrinfo ENOTFOUND dataset.genshin-dictionary.com
    at ClientRequest.<anonymous> (file:///Users/hakubill/genshin-langdata/node_modules/node-fetch/src/index.js:108:11)
    at ClientRequest.emit (node:events:520:28)
    at TLSSocket.socketErrorListener (node:_http_client:442:9)
    at TLSSocket.emit (node:events:520:28)
    at emitErrorNT (node:internal/streams/destroy:164:8)
    at emitErrorCloseNT (node:internal/streams/destroy:129:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  type: 'system',
  errno: 'ENOTFOUND',
  code: 'ENOTFOUND',
  erroredSysCall: 'getaddrinfo'
}

Node.js v17.4.0

I got this and I think there's no typo in my translation right?.

[xicri]

@Bill-Haku Hmm, I modified the DNS record for dataset.genshin-dictionary.com 2 hours ago, so perhaps the change is not applied to DNS servers in China yet. Or GFW blocks it...?

But in the meantime, you can ignore this error because JSON5 is already parsed before accessing https://dataset.genshin-dictionary.com/words.json. This means your JSON5 is probably valid.

[xicri]

All the problems are resolved except for the test!
Thank you, I will work on fixing the error on the test.

[Bill-Haku]

@Bill-Haku Hmm, I modified the DNS record for dataset.genshin-dictionary.com 2 hours ago, so perhaps the change is not applied to DNS servers in China yet. Or GFW blocks it...?

But in the meantime, you can ignore this error because JSON5 is already parsed before accessing https://dataset.genshin-dictionary.com/words.json. This means your JSON5 is probably valid.

@xicri Maybe, it was caused by DNS. Anyway, I tried again on my local and nothing unexpected happened. Also, GFW will not block the site as there's nothing illegal or sensitive.

[xicri]

Sorry for the change request after the approval.
I found some additional wrong translations.

[xicri]

Thanks, everything is fine 👍

[Bill-Haku]

I've followed your instructions but it seems that there's still some problem...

[xicri]

89e629e and 3d7e2ea seem unnecessary and I want to remove them. Other commits look good.
How about the following steps to remove the most recent 3 commits and add e525353 again?:

1. Run git reset HEAD^ three times. (git reset HEAD^ removes the latest commit)
2. Modify dataset/dictionary/artifacts.json5 to manually add trailing commas like e525353, then commit it.
3. git push --force origin zh-translate

[xicri]

Oops. sorry, I looked carefully and found some other duplicated commits.

[Bill-Haku]

It seems that the Github Action Check has passed

[xicri]

Yes, the test has passed 🎉
Maybe the code itself has no problem, but too dirty commit history may cause a problem if I have to investigate the history in the future.
I'm not sure why the problem still persists. Can I clean up the commit history on my end?

[Bill-Haku]

No problem. Thanks for helping me send this PR. お疲れさまでした!

[xicri]

Thanks, I've fixed the commits.

[xicri]

Merged. Thanks for your tough work!

I will modify genshin-dictionary repository to optimize the UI to show your Chinese translations next weekend.

It was fun to collaborate with you today. 謝謝!