Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated project to be usable on Symfony 3 #10

Merged
merged 4 commits into from
Apr 18, 2016

Conversation

lucia-ionica
Copy link

Hi there,

I managed to commit the changes so the project can be used with by Symfony3 projects.

Lucia

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 98.419% when pulling 892415c on lucia-ionica:master into c8acdee on xiidea:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 98.419% when pulling 0c3e8b1 on lucia-ionica:master into c8acdee on xiidea:master.

@ronisaha
Copy link
Member

Your commit failing my test cases so assuming will not work with previous version of symfony. So I may need to create another branch for support older version and keep master for symfony3. And also need to update the test case.
If you could manage to update the test cases and run the unit tests. If the test cases passes then push your code. In the mean time let see what I can do.

Thanks for your support.

BR
Roni

Lucia Ionica added 2 commits March 23, 2016 19:03
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bea8a77 on lucia-ionica:master into c8acdee on xiidea:master.

@ronisaha ronisaha merged commit bea8a77 into xiidea:master Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants