Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language switch #40

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Language switch #40

merged 5 commits into from
Oct 2, 2024

Conversation

jackd248
Copy link
Contributor

Adds a simple language switch to the frontend to support multi language manuals.

maikschneider
maikschneider reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@maikschneider maikschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some adjustments to the frontend rendering of the menu: When having a longer language title, the menu was jumping.

What do you think about the fixed position?

Screenshot 2024-10-02 at 11 45 12

@jackd248
Copy link
Contributor Author

jackd248 commented Oct 2, 2024

I'm fine with the adjustments.

@maikschneider maikschneider merged commit 518467e into main Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maikschneider maikschneider maikschneider left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackd248 @maikschneider