Multiple fixes #15
Merged
Multiple fixes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxlaverse
commented
Feb 27, 2018
maxlaverse
commented
- fix that multiple chunks of JSON are sent by Docker for Mac
- stop using deprecated file copy API endpoint for API versions >= 1.20
- replace ENTRYPOINTs with CMDs
- deal with extended pax headers in tar archives
- fix tests
SOLUTION: use CMD instead of ENTRYPOINT for starting the package build process
docker, at least the Mac incarnation, creates pax headers in archives. Patch deals with pax header usage for long paths. See http://pubs.opengroup.org/onlinepubs/9699919799/utilities/pax.html#tag_20_92_13_03
Breakage introduced in 2726308
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.