Filter dependencies by target #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d976ec.
sdidla
reviewed
Sep 12, 2022
sdidla
reviewed
Sep 12, 2022
|
thanks @sdidla for your feedback. I had no time last week to do those changes. I´m going to apply this target concept also in history and graph commands to be consistent. |
Juantri94
approved these changes
Sep 21, 2022
|
@sdidla Can you take a look at the latest changes? |
sdidla
reviewed
Sep 21, 2022
| @@ -16,8 +30,11 @@ struct CompareCommand: ParsableCommand { | |||
| ) | |||
| var gitObjects: [String] = ["HEAD", "main", "master"] | |||
|
|
|||
| @Option(help: "The Pod to compare. Omitting this generates compares a virtual `App` target that imports all Pods") | |||
| @Option(help: "The Pod to compare. If you specify something, target parameter will be ommited") | |||
There was a problem hiding this comment.
See comments in the README
Co-authored-by: Shammi Didla <sdidla@gmail.com>
Co-authored-by: Shammi Didla <sdidla@gmail.com>
Co-authored-by: Shammi Didla <sdidla@gmail.com>
Co-authored-by: Shammi Didla <sdidla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7
Currently we get all the dependencies from the
Podfile.lockwithout evaluating which targets those dependencies belongs. We want to introduce a new parameter (target) to filter only the dependencies for that target.