-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code clarification #32
Comments
Asking about the polygon intersection because seeing:
|
You could instead use:
|
HI @johnwlambert, I have updated some comments in the code that you mentioned for further clarification. Thank you for bringing those points. Also, I have checked your code, which looks great. The only downside I found now is that the function of "shapely_polygon_intersection" takes a longer time than "convex_hull_intersection". As speed is crucial to multi-object tracking. I am not sure if it is good to use the new function. For the error brought by the convex_hull_intersection, it can be simply resolved by adding "try exception" in the code. |
Hi @xinshuoweng , thanks for open-sourcing your 3d tracking code. Very nice to find this. I have a few questions for you about the coordinate system and dimension ordering:
The docstring here doesn't look correct -- mentions image projection.
https://github.com/xinshuoweng/AB3DMOT/blob/master/main.py#L115
It looks like the tracking reference frame is the camera coordinate frame, rather than an egovehicle, LiDAR, or world frame. Might be helpful to clarify this in the docstrings. Unlike KITTI, most new datasets now annotate in an egovehicle, LiDAR, or world frame, instead of the camera frame, meaning x is now associated with length, y with width, and z with height, e.g. Argoverse or Nuscenes
https://github.com/xinshuoweng/AB3DMOT/blob/master/main.py#L134
What is the reason for the reordering back and forth of the bounding box information? Might be helpful to indicate the order expected (since this threw me off initially)
https://github.com/xinshuoweng/AB3DMOT/blob/master/main.py#L348
Any particular reason to not use Shapely.geometry for polygon intersection? I see that you've provided your own function here:
https://github.com/xinshuoweng/AB3DMOT/blob/master/main.py#L48
The text was updated successfully, but these errors were encountered: