Image comparison tool #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdinger
force-pushed
the
image_load
branch
2 times, most recently
from
5364fd4
to
4edbd02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to work pretty well. It compares two run ids at the same bitrate with the same picture. Things get a little weird if both sets don't have the same image sets or bitrates which can get confusing.
I'm using bpp of 0.1:0.1:1.0 as my ranges. Is that the range that you would use? I can change it. I'd prefer if it be set to something really good for now so it doesn't have to be changed later.
rd_tool probably needs to compress the images so they don't take up so much space. Maybe imagemagick will do it? I'm not really sure but it seems like a good idea to check before this is uploaded.
I might be able to consolidate some things...I'm not really sure but I think I'm done with it for today.