Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible problem in silk/MacroCount.h #35

Closed
petrufm opened this issue Feb 28, 2017 · 1 comment
Closed

Possible problem in silk/MacroCount.h #35

petrufm opened this issue Feb 28, 2017 · 1 comment

Comments

@petrufm
Copy link

petrufm commented Feb 28, 2017

In the file silk/MacroCount.h line 694, shouldn't the return type of the silk_LIMIT_32 function be "opus_int32" instead of "opus_int"? All parameters and the variable used to compute the return value are declared as "opus_int32". Moreover, in the case of other functions from the same file, there is a consistency between these types and the return type of the corresponding functions. I detected this automatically using a CodeSonar plugin.
@jmvalin
Copy link
Member

jmvalin commented May 30, 2017

Thanks for reporting this. Just landed the fix.

@jmvalin jmvalin closed this as completed May 30, 2017
ghost pushed a commit that referenced this issue May 30, 2017
@jmvalin
silk_LIMIT_32() should return an opus_int32 (not opus_int)
aef369f 
Thanks to petrufm for pointing that out:
#35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmvalin @petrufm