-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove calculation of old daalatools metrics. #89
Conversation
@@ -369,6 +376,7 @@ fi | |||
echo "$ENCTIME" | |||
|
|||
if [ -f "$VMAF" ]; then | |||
echo "$VMAF -r $FILE -d $BASENAME.y4m --aom_ctc v1.0 --csv -o $BASENAME-vmaf.csv --thread 1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good idea,
When we avoid those computation all-together, we would save small amount of time, and when there are lot of jobs, we would save some decent amount of time,
But for doing that, we would require to update the BD-rate report, write_lines(), and write_results() to have it in right way.
This is hacky way but works,
Updated commnet with benchmark, I was testing yesterday with libvmaf alone.
Edit:
For a single QP it was around 5 seconds difference for CPU 9 in liboam
"env x=63 ENCODING_MODE=quantizer bash create_optimiser.sh ~/awcy/media/objective-1-fast/blue_sky_360p_60f.y4m" "env x=63 ENCODING_MODE=quantizer bash create_optimiser2.sh ~/awcy/media/objective-1-fast/blue_sky_360p_60f.y4m"
Benchmark #1: env x=63 ENCODING_MODE=quantizer bash create_optimiser.sh ~/awcy/media/objective-1-fast/blue_sky_360p_60f.y4m
Time (mean ± σ): 36.266 s ± 0.135 s [User: 35.766 s, System: 0.303 s]
Range (min … max): 36.142 s … 36.463 s 10 runs
Benchmark #2: env x=63 ENCODING_MODE=quantizer bash create_optimiser2.sh ~/awcy/media/objective-1-fast/blue_sky_360p_60f.y4m
Time (mean ± σ): 32.098 s ± 0.202 s [User: 31.650 s, System: 0.257 s]
Range (min … max): 31.602 s … 32.308 s 10 runs
Summary
'env x=63 ENCODING_MODE=quantizer bash create_optimiser2.sh ~/awcy/media/objective-1-fast/blue_sky_360p_60f.y4m' ran
1.13 ± 0.01 times faster than 'env x=63 ENCODING_MODE=quantizer bash create_optimiser.sh ~/awcy/media/objective-1-fast/blue_sky_360p_60f.y4m'
@@ -331,32 +331,39 @@ PIXELS=$(($WIDTH*$HEIGHT*$FRAMES)) | |||
|
|||
echo "$x" "$PIXELS" "$SIZE" | |||
|
|||
PSNR=$(cat "$BASENAME-psnr.out" | grep Total) | |||
#PSNR=$(cat "$BASENAME-psnr.out" | grep Total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would require to comment out L327
"$DUMP_PSNR" -a "$FILE" "$BASENAME.y4m" > "$BASENAME-psnr.out"
to make sure it is not computing PSNR
19387dd completes removal |
No description provided.