Replace request-promise-native (and by extension, request) with @root/request. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roncli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package
request, used byrequest-promise-native, has been deprecated for quite some time now, so it is a good idea to replace it.Notes:
This PR replaces
request-promise-nativewith@root/request, one of many replacements for the deprecatedrequestlibrary. I used this one simply because it's the one I'm most familiar with and supports promises, but there are a litany of replacements for therequestlibrary, so if you want to choose another, feel free to discard this PR and use one you're more comfortable with! 🙂Also, I do not have anything to create a shrinkwrap.yaml file, so I hand-edited it. If you accept this PR, I recommend regenerating that YAML file on your end to make sure it's fine.