Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to retrieve schema type and transaction version #55

Merged
merged 6 commits into from
Jul 11, 2020

Conversation

MikeEdgar
Copy link
Member

Fixes #45
Fixes #54

- Replace reference code `CharSequence` with `EDIReference` type in
`EDIOutputErrorReporter`
- Re-factoring in `ProxyEventHandler` to provide schema type
- Test class updates to account for callback method changes to include
`EDIReference` instead of reference code
@MikeEdgar MikeEdgar added this to the v1.9.0 milestone Jul 11, 2020
@coveralls
Copy link

coveralls commented Jul 11, 2020

Pull Request Test Coverage Report for Build 165688380

  • 101 of 103 (98.06%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 96.866%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/io/xlate/edi/internal/stream/tokenization/EDIFACTDialect.java 0 1 0.0%
src/main/java/io/xlate/edi/internal/stream/tokenization/StreamEvent.java 7 8 87.5%
Totals Coverage Status
Change from base Build 163985778: 0.03%
Covered Lines: 4172
Relevant Lines: 4307

💛 - Coveralls

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

97.0% 97.0% Coverage
0.0% 0.0% Duplication

@MikeEdgar MikeEdgar merged commit 06e3ddb into master Jul 11, 2020
@MikeEdgar MikeEdgar deleted the 45_access_current_schema_node branch July 11, 2020 15:14
@MikeEdgar
Copy link
Member Author

@josecaster - FYI, when the next version (1.9 is released) you will be able to retrieve the EDIReference directly from the EDIStreamReader for the current event (getSchemaTypeReference on the reader). This should be more convenient than looking it up from the Schema using the information from the Location.

@josecaster
Copy link

Exactly, great update. looking forward to it.

@MikeEdgar
Copy link
Member Author

@josecaster - version 1.9.0 is now available (FYI).

@josecaster
Copy link

josecaster commented Aug 1, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants