Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the option to cache all metadata #47

Closed
xlcnd opened this issue May 20, 2014 · 3 comments
Closed

Create the option to cache all metadata #47

xlcnd opened this issue May 20, 2014 · 3 comments
Assignees
@xlcnd
Labels
P1
Milestone
v3.3.1

Comments

@xlcnd
Copy link
Owner

xlcnd commented May 20, 2014

In addition, we can create:

  • a new metadata provider that pulls metadata from that cache.
  • an option to only go to the web if the data is not available in the cache.
  • an option to go local if internet connection is not available.
@xlcnd
Copy link
Owner Author

xlcnd commented May 28, 2014

isbntools._metadata.query is the right point to put these hooks..

@xlcnd xlcnd added P1 and removed P3 labels Jun 1, 2014
@xlcnd xlcnd added this to the v3.2.5 milestone Jun 2, 2014
@xlcnd xlcnd self-assigned this Jun 2, 2014
xlcnd added a commit that referenced this issue Jun 2, 2014
@xlcnd
add a cache to metadata (#47)
8c51073
xlcnd added a commit that referenced this issue Jun 2, 2014
@xlcnd
add a cache to metadata (#47)
2a43d6c
@xlcnd
Copy link
Owner Author

xlcnd commented Jun 4, 2014

  • "an option to only go to the web if the data is not available in the cache." this is the default behaviour.
  • "a new metadata provider that pulls metadata from that cache." called cache? How to solve the 'service ambiguity'? The way things are, the provider just have to redefine the key...!
  • "an option to go local if internet connection is not available." ???

@xlcnd
Copy link
Owner Author

xlcnd commented Jun 4, 2014

Keep it simple, just add a cache.

@xlcnd xlcnd closed this as completed Jun 4, 2014
xlcnd added a commit that referenced this issue Jun 4, 2014
@xlcnd
keep it simple, just add a cache (close #47)
c1a5b5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xlcnd xlcnd

Labels
P1
Projects
None yet
Milestone
v3.3.1
Development

No branches or pull requests
1 participant
@xlcnd