Code bugs in calculating lossess?

[zachpvin]

I noticed that there are mismatched keys name in weight_dict, effectively making the losses calculation skipped loss_segments and loss_actionness in this line:

TadTR/engine.py

Lines 45 to 46 in 3af0abc

	losses = sum(loss_dict[k] * weight_dict[k]
	for k in loss_dict.keys() if k in weight_dict)

Looking at the weight_dict, loss_seg is used rather than loss_segments

TadTR/models/tadtr.py

Lines 498 to 501 in 3af0abc

	weight_dict = {
	'loss_ce': args.cls_loss_coef,
	'loss_seg': args.seg_loss_coef,
	'loss_iou': args.iou_loss_coef}

TadTR/models/tadtr.py

Line 299 in 3af0abc

losses['loss_segments'] = loss_segment.sum() / num_segments

For actionness, it's assigned as loss_iou instead of loss_actionness, which replaced the loss_iou by segments loss.

TadTR/models/tadtr.py

Line 327 in 3af0abc

losses['loss_iou'] = loss_actionness

Are these bugs? Could you confirm it? Thanks.

[xlliu7]

Hi @zachpvin,
Thanks for raising this issue. This is an error in the conversion from internal code to public code. It has been fixed in commit 983ae14.