Remove comtypes requirement #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks awesome! Yes, definitely a good move also in light of this. There are no unit tests for this functionality. Instead, the following has to be tested manually (which I did and I couldn't find any issues):
|
|
Great. What remains to be done before merger? Anything for |
|
Nothing to be done, I'll take care of that before release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1443
What's missing:
docs/whatsnew.rstbecause I'm not sure how you handle in-development items.docs/locales/**/*.pofiles that popped up withgit grep --files-with-matches comtypesbecause they look old and I don't know how to use them anyway.