Add nappgui #3994
Closed
Add nappgui #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
use add_patches to add patch, you can see other packages |
waruqi
reviewed
May 10, 2024
packages/n/nappgui/xmake.lua
Outdated
| package:add("includedirs", "inc", "inc/osapp") | ||
|
|
||
| --dylibs are built to `bin` | ||
| package:add("linkdirs", "bin") |
waruqi
reviewed
May 10, 2024
packages/n/nappgui/xmake.lua
Outdated
|
|
||
| --dylibs are built to `bin` | ||
| package:add("linkdirs", "bin") | ||
| package:add("rpathdirs", package:installdir("bin")) |
waruqi
reviewed
May 10, 2024
packages/n/nappgui/xmake.lua
Outdated
| package:add("rpathdirs", package:installdir("bin")) | ||
|
|
||
| --static libraries are built to `lib` | ||
| package:add("linkdirs", "lib") |
There was a problem hiding this comment.
xmake will add it automatically, please remove it
There was a problem hiding this comment.
xmake didn't add it for the bin directory, for some reason the .dylibs are built into there
waruqi
reviewed
May 10, 2024
packages/n/nappgui/xmake.lua
Outdated
| --static libraries are built to `lib` | ||
| package:add("linkdirs", "lib") | ||
|
|
||
| package:add("links", "core", "draw2d", "geom2d", "gui", "inet", "osapp", "osbs", "osgui", "sewer") |
There was a problem hiding this comment.
please use add_links in description scope.
waruqi
reviewed
May 10, 2024
packages/n/nappgui/xmake.lua
Outdated
|
|
||
| on_test(function (package) | ||
| assert(package:check_csnippets({test = [[ | ||
| typedef struct _app_t App; |
There was a problem hiding this comment.
too long test, please simplify it
|
Thanks for review, I'll fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on macOS requires frang75/nappgui_src#136 to be merged, and I don't know how to add it as a patch.