check_links, check_cincludes, check_cxxincludes export as private #1720

idealvin · 2021-10-02T00:38:57Z

Is your feature request related to a problem? Please describe.

-- libco
check_cincludes("HAS_BACKTRACE_H", "backtrace.h")
check_cxxincludes("HAS_CXXABI_H", "cxxabi.h")
check_links("HAS_LIBBACKTRACE", "backtrace")

By default, macros and links exported from check_xxx will be public and can be seen in projects depends on that target. At present, we are not able to set them private.

Describe the solution you'd like

check_cincludes("HAS_BACKTRACE_H", "backtrace.h", { public = false })
check_cxxincludes("HAS_CXXABI_H", "cxxabi.h", { public = false })
check_links("HAS_LIBBACKTRACE", "backtrace", { public = false })

or

check_cincludes("HAS_BACKTRACE_H", "backtrace.h", { private = true })
check_cxxincludes("HAS_CXXABI_H", "cxxabi.h", { private = true })
check_links("HAS_LIBBACKTRACE", "backtrace", { private = true })

So the macros and links can only be seen in the current target.

The text was updated successfully, but these errors were encountered:

idealvin · 2021-10-02T00:42:03Z

Here is the cmake-way:

check_include_files(backtrace.h HAS_BACKTRACE)
check_include_file_cxx(cxxabi.h HAS_CXXABI)
if(HAS_BACKTRACE)
    target_compile_definitions(co PRIVATE HAS_BACKTRACE_H)
    target_link_libraries(co PRIVATE backtrace)
endif()
if(HAS_CXXABI)
    target_compile_definitions(co PRIVATE HAS_CXXABI_H)
endif()

xq114 · 2021-10-02T02:33:43Z

option("HAS_BACKTRACE") add_cincludes("backtrace.h")
option("HAS_BACKTRACE_LIB") add_clinks("backtrace")
option("HAS_CXXABI") add_cxxincludes("cxxabi.h")

target("co")
if has_config("HAS_BACKTRACE") and has_config("HAS_BACKTRACE_LIB") then
    add_defines("HAS_BACKTRACE_H")
    add_syslinks("backtrace")
end
if has_config("HAS_CXXABI") then
    add_defines("HAS_CXXABI_H", {public = true})
end

I'm not sure if the following simpler code works

option("HAS_BACKTRACE") add_cincludes("backtrace.h")
option("HAS_BACKTRACE_LIB") add_clinks("backtrace")
option("HAS_CXXABI")
    add_cxxincludes("cxxabi.h")
    add_defines("HAS_CXXABI_H", {public = true})

target("co")
	if has_config("HAS_BACKTRACE") and has_config("HAS_BACKTRACE_LIB") then
	    add_defines("HAS_BACKTRACE_H")
	    add_syslinks("backtrace")
	end
	add_options("HAS_CXXABI")

idealvin · 2021-10-02T02:36:57Z

@xq114

I have tried to modify the check_xxx.lua. It seems that config in options does not work.

function check_cincludes(definition, includes, opt)
    opt = opt or {}
    local optname = "__" .. (opt.name or definition)
    local is_public = opt.public or false
    option(optname)
        add_cincludes(includes)
        add_defines(definition, { public = is_public })
    option_end()
    add_options(optname)
end

xq114 · 2021-10-02T15:10:52Z

Maybe currently option.add_defines() does not support extra configs. @waruqi can extra configs be added to option.add_defines(), and a set of other apis?

As for now, you can try the former solution, which does not need the config-in-option feature

waruqi · 2021-10-02T15:36:37Z

都是国人，就没必要 en 文了，我回复好累。

这个主要原因是 check_xxx 辅助接口，内部用了 option() 域定义

而所有 target/option 等域定义都会自动关闭上个域，进入当前域。

也就是说进入 option() 后，option_end 退出就自动进入 root 域了，所以 check_xxx 在 target 里面设置好，之后的 add_options 其实是被设置在 root 域下，没对当前 target 生效

另外也会干扰后面用户自己的 add_defines 等对 target 的设置。。

所以，也算是个 bug ，目前只能全局生效，对特定 target 设置 check_xxx 就会有问题。。

我刚弄了个 patch ，通过新开放的 save_scope/restore_scope 接口，也保存之前的域访问，这对于一些封装性的自定义接口也会有用

可以自己先测试下 scope 分支，应该可以了的。

waruqi · 2021-10-02T15:45:45Z

option.add_defines 等接口目前不考虑加 public ，因为只有 add_options 到特定 target 才会生效。我记得 add_options 是支持 public 设置的，目前只能到这个粒度

另外，现在这个 issue 的本质问题就是之前说的 scope 重入中断问题，跟是否 public 没什么关系

当然，你可以不走 check_xxx，自己定义 option 去配置 check 设置到特定 target 也就解决了。

idealvin · 2021-10-02T15:47:52Z

感觉是 option的机制问题，与cmake不大一样，xmake option 与里面的语句绑定构成了option域，而cmake option并没有绑定语句，因此没有option域

…

---Original--- From: ***@***.***> Date: Sat, Oct 2, 2021 23:36 PM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [xmake-io/xmake] check_links, check_cincludes, check_cxxincludes export as private (#1720) 都是国人，就没必要 en 文了，我回复好累。这个主要原因是 check_xxx 辅助接口，内部用了 option() 域定义而所有 target/option 等域定义都会自动关闭上个域，进入当前域。也就是说进入 option() 后，option_end 退出就自动进入 root 域了，所以 check_xxx 在 target 里面设置好，之后的 add_options 其实是被设置在 root 域下，没对当前 target 生效另外也会干扰后面用户自己的 add_defines 等对 target 的设置。。所以，也算是个 bug ，目前只能全局生效，对特定 target 设置 check_xxx 就会有问题。。我刚弄了个 patch ，通过新开放的 save_scope/restore_scope 接口，也保存之前的域访问，这对于一些封装性的自定义接口也会有用可以自己先测试下 scope 分支，应该可以了的。 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

idealvin · 2021-10-02T15:48:59Z

ok，我后面试试，感谢回复

…

---Original--- From: ***@***.***> Date: Sat, Oct 2, 2021 23:45 PM To: ***@***.***>; Cc: ***@***.******@***.***>; Subject: Re: [xmake-io/xmake] check_links, check_cincludes, check_cxxincludes export as private (#1720) option.add_defines 等接口目前不考虑加 public ，因为只有 add_options 到特定 target 才会生效。我记得 add_options 是支持 public 设置的，目前只能到这个粒度另外，现在这个 issue 的本质问题就是之前说的 scope 重入中断问题，跟是否 public 没什么关系当然，你可以不走 check_xxx，自己定义 option 去配置 check 设置到特定 target 也就解决了。 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

waruqi · 2021-10-02T15:49:28Z

option("HAS_BACKTRACE") add_cincludes("backtrace.h")
option("HAS_BACKTRACE_LIB") add_clinks("backtrace")
option("HAS_CXXABI") add_cxxincludes("cxxabi.h")

target("co")
if has_config("HAS_BACKTRACE") and has_config("HAS_BACKTRACE_LIB") then
    add_defines("HAS_BACKTRACE_H")
    add_syslinks("backtrace")
end
if has_config("HAS_CXXABI") then
    add_defines("HAS_CXXABI_H", {public = true})
end

I'm not sure if the following simpler code works

option("HAS_BACKTRACE") add_cincludes("backtrace.h")
option("HAS_BACKTRACE_LIB") add_clinks("backtrace")
option("HAS_CXXABI")
    add_cxxincludes("cxxabi.h")
    add_defines("HAS_CXXABI_H", {public = true})

target("co")
	if has_config("HAS_BACKTRACE") and has_config("HAS_BACKTRACE_LIB") then
	    add_defines("HAS_BACKTRACE_H")
	    add_syslinks("backtrace")
	end
	add_options("HAS_CXXABI")

@idealvin 你可以按照这个方式自己配置，就跟 cmake 一样了，这跟 option 机制没关系，它本身不会绑定域

check_xxx 只是辅助接口，目前自带 defines 启用，所以设置上更加简化，只需要一行，而不是像 cmake 一样，每个检测，要加一堆 if add

waruqi · 2021-10-02T15:51:42Z

includes里面的 check_xxx 都是辅助接口，只是利用了 option 的特性，如果你觉得不想自带绑定 target

那么，可以自己参考 check_xxx 实现，封装自己的辅助接口，直接基于 option 搞。

idealvin · 2021-10-03T01:58:19Z

option("HAS_BACKTRACE") add_cincludes("backtrace.h")
option("HAS_BACKTRACE_LIB") add_clinks("backtrace")
option("HAS_CXXABI") add_cxxincludes("cxxabi.h")

target("co")
if has_config("HAS_BACKTRACE") and has_config("HAS_BACKTRACE_LIB") then
    add_defines("HAS_BACKTRACE_H")
    add_syslinks("backtrace")
end
if has_config("HAS_CXXABI") then
    add_defines("HAS_CXXABI_H", {public = true})
end
I'm not sure if the following simpler code works
option("HAS_BACKTRACE") add_cincludes("backtrace.h")
option("HAS_BACKTRACE_LIB") add_clinks("backtrace")
option("HAS_CXXABI")
    add_cxxincludes("cxxabi.h")
    add_defines("HAS_CXXABI_H", {public = true})

target("co")
	if has_config("HAS_BACKTRACE") and has_config("HAS_BACKTRACE_LIB") then
	    add_defines("HAS_BACKTRACE_H")
	    add_syslinks("backtrace")
	end
	add_options("HAS_CXXABI")
@idealvin 你可以按照这个方式自己配置，就跟 cmake 一样了，这跟 option 机制没关系，它本身不会绑定域

check_xxx 只是辅助接口，目前自带 defines 启用，所以设置上更加简化，只需要一行，而不是像 cmake 一样，每个检测，要加一堆 if add

这个可以，我用这个吧

waruqi mentioned this issue Oct 2, 2021

save and restore scope #1722

Merged

waruqi added the bug label Oct 2, 2021

waruqi added this to the v2.5.8 milestone Oct 2, 2021

waruqi added the improvement label Oct 2, 2021

idealvin closed this as completed Oct 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

check_links, check_cincludes, check_cxxincludes export as private #1720

check_links, check_cincludes, check_cxxincludes export as private #1720

idealvin commented Oct 2, 2021 •

edited

Loading

idealvin commented Oct 2, 2021

xq114 commented Oct 2, 2021 •

edited

Loading

idealvin commented Oct 2, 2021 •

edited

Loading

xq114 commented Oct 2, 2021

waruqi commented Oct 2, 2021

waruqi commented Oct 2, 2021

idealvin commented Oct 2, 2021 via email

idealvin commented Oct 2, 2021 via email

waruqi commented Oct 2, 2021 •

edited

Loading

waruqi commented Oct 2, 2021

idealvin commented Oct 3, 2021

check_links, check_cincludes, check_cxxincludes export as private #1720

check_links, check_cincludes, check_cxxincludes export as private #1720

Comments

idealvin commented Oct 2, 2021 • edited Loading

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

idealvin commented Oct 2, 2021

xq114 commented Oct 2, 2021 • edited Loading

idealvin commented Oct 2, 2021 • edited Loading

xq114 commented Oct 2, 2021

waruqi commented Oct 2, 2021

waruqi commented Oct 2, 2021

idealvin commented Oct 2, 2021 via email

idealvin commented Oct 2, 2021 via email

waruqi commented Oct 2, 2021 • edited Loading

waruqi commented Oct 2, 2021

idealvin commented Oct 3, 2021

idealvin commented Oct 2, 2021 •

edited

Loading

xq114 commented Oct 2, 2021 •

edited

Loading

idealvin commented Oct 2, 2021 •

edited

Loading

waruqi commented Oct 2, 2021 •

edited

Loading