Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path with xxx-include not included in pch #5270

Closed
MaxwellGengYF opened this issue Jun 28, 2024 · 7 comments
Closed

Path with xxx-include not included in pch #5270

MaxwellGengYF opened this issue Jun 28, 2024 · 7 comments
Labels
Milestone

Comments

@MaxwellGengYF
Copy link
Contributor

Xmake 版本

xmake v2.9.3+dev.7f0f823bc

操作系统版本和架构

Windows 11

描述问题

当add_includedirs 路径为 xxx-include,如 modules/my-include 时,set_pcxxheader 定义的pch编译不会正确 include

期待的结果

正常接受 include

工程配置

add_includedirs("test/my-include");
set_pcxxheader("pch.h");

附加信息和错误日志

fatal error: 'xx.h' file not found

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Xmake version

xmake v2.9.3+dev.7f0f823bc

Operating system version and architecture

Windows 11

Describe the problem

When the add_includedirs path is xxx-include, such as modules/my-include, the pch defined by set_pcxxheader will not be compiled correctly include

Expected results

Normally accept include

Project configuration

add_includedirs("test/my-include");
set_pcxxheader("pch.h");

Additional information and error logs

fatal error: 'xx.h' file not found

@waruqi
Copy link
Member

waruqi commented Jun 28, 2024

给个完整 project example

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Give a complete project example

@MaxwellGengYF
Copy link
Contributor Author

waruqi added a commit that referenced this issue Jul 1, 2024
@waruqi
Copy link
Member

waruqi commented Jul 1, 2024

再试试,#5284

@waruqi waruqi added this to the v2.9.4 milestone Jul 1, 2024
waruqi added a commit that referenced this issue Jul 1, 2024
@MaxwellGengYF
Copy link
Contributor Author

没问题了。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants