fix detection strategy for MSVC/VS2017+ #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes the MSVC/VS 2017 detection problem discussed within <xmake-io#225> .# Discussion MSVC/VS versions >= 15.0 will no longer be setting registry entries for tool location purposes. But `vswhere` (included with MSVC/VS versions >= 15.2, and placed in a guaranteed location) can instead be used to find the needed path. `os.runv(...)` is used as the tool to gather `vswhere` output instead of `($shell ...)` in order to avoid some `($shell ...)` limitations. Commands containing white space and/or special characters (eg, '[', ')') are difficult or impossible to pass through the current `($shell ...)` implementation, causing application exceptions. Both white space and the noted special characters are needed to construct the required `vswhere` command. ref: <https://github.com/Microsoft/vswhere/blob/master/README.md> @@ <https://archive.is/mEmdu>
rivy
force-pushed
the
fix.find_vstudio
branch
from
bcecc28
to
92f1645
Compare
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix detection strategy for MSVC/VS2017+
rc.exenot found unless on PATH duringxmake config#225Discussion
MSVC/VS versions >= 15.0 will no longer be setting registry entries for tool location purposes. But
vswhere(included with MSVC/VS versions >= 15.2, and placed in a guaranteed location) can instead be used to find the needed path.os.runv(...)is used as the tool to gathervswhereoutput instead of($shell ...)in order to avoid some($shell ...)limitations. Commands containing white space and/or special characters (eg, '[', ')') are difficult or impossible to pass through the current($shell ...)implementation, causing application exceptions. Both white space and the noted special characters are needed to construct the requiredvswherecommand.ref: https://github.com/Microsoft/vswhere/blob/master/README.md @@ https://archive.is/mEmdu