Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mats-claassen That's the correct fix for the issue I've opened a few weeks ago. This way custom cells with xib files can be declared using
<Class>.self
or"<Class>"
. It's much cleaner than usingNSStringFromClass
as you've implemented in the other fix:XLFormViewController.cellClassesForRowDescriptorTypes()[XLFormRowDescriptorTypeRate] = XLFormRatingCell.self
or
XLFormViewController.cellClassesForRowDescriptorTypes()[XLFormRowDescriptorTypeRate] = "XLFormRatingCell"
I would revert the change done in d8ece14 and use this one.