Feature/android support #2
Conversation
mcousillas6
force-pushed
the
feature/androidSupport
branch
from
f0f07af
to
f0d6b38
Compare
| public class LineLogin extends ReactContextBaseJavaModule { | ||
| private static final String MODULE_NAME = "LineLoginManager"; | ||
| private static final String ERROR = "ERROR"; | ||
| private static final String CHANNEL_ID = "1544017747"; |
There was a problem hiding this comment.
as you said, this must be received as parameter
|
|
||
| @ReactMethod | ||
| public void loginWithPermissions(final Promise promise) { | ||
| login(promise); |
There was a problem hiding this comment.
this way, it looks you are not passing the permissions to the Line login.
There was a problem hiding this comment.
I'm not, the problem here is that the android login does not accept any kind of parameters to set permissions. I did this just to match the iOS api that has that feature.
example/android/settings.gradle
Outdated
| include ':react-native-line' | ||
| project(':react-native-line').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-line/android') | ||
|
|
||
| include ':app' |
example/index.android.js
Outdated
| @@ -27,7 +27,7 @@ class example extends Component { | |||
| } | |||
|
|
|||
| _handleClickLogout () { | |||
| LoginManager.logout() | |||
| // LoginManager.logout() | |||
There was a problem hiding this comment.
why is this commented? can be deleted?
| loginResult = LineLoginApi.getLoginResultFromIntent(data); | ||
| switch (loginResult.getResponseCode()) { | ||
| case SUCCESS: | ||
| loginPromise.resolve(loginResult.getLineCredential().getAccessToken().getAccessToken()); |
There was a problem hiding this comment.
This doesn't seem to be compatible with iOS. On iOS the result is sent as a dictionary with two keys: accessToken and profile.
| @ReactMethod | ||
| public void logout(final Promise promise) { | ||
| loginResult = null; | ||
| promise.resolve(new Object()); |
There was a problem hiding this comment.
To correctly logout the user from Line you need to call to LineApiClient.logout
|
|
||
| @ReactMethod | ||
| public void getUserProfile(final Promise promise) { | ||
| if (loginResult != null) { |
There was a problem hiding this comment.
I think that a better approach would be using the LineApiClient to get the actual user profile. The current approach will work only if you called the login function first and it will return a cached version of the profile. Thoughts?
|
|
||
| @ReactMethod | ||
| public void currentAccessToken(final Promise promise) { | ||
| if (loginResult != null) { |
There was a problem hiding this comment.
You can get it from the LineApiClient (https://developers.line.me/en/docs/android-sdk/managing-access-tokens/)
| @@ -22,7 +23,8 @@ public boolean getUseDeveloperSupport() { | |||
| @Override | |||
| protected List<ReactPackage> getPackages() { | |||
| return Arrays.<ReactPackage>asList( | |||
| new MainReactPackage() | |||
| new MainReactPackage(), | |||
| new LineLoginPackage() | |||
| private LineLoginResult loginResult; | ||
| private final ActivityEventListener mActivityEventListener = new BaseActivityEventListener() { | ||
| @Override | ||
| public void onActivityResult(Activity activity, int requestCode, int resultCode, Intent data) { | ||
| super.onActivityResult(activity, requestCode, resultCode, data); | ||
| if (requestCode != REQUEST_CODE) { | ||
| loginPromise.reject(ERROR, "Unsupported request"); | ||
| currentPromise.reject(ERROR, "Unsupported request"); |
There was a problem hiding this comment.
don't you need to check if currentPromise is null here too?
| } | ||
|
|
||
| private LineApiClient getLineApiClient() { | ||
| if(lineApiClient == null) { |
| loginPromise = promise; | ||
| Intent intent = LineLoginApi.getLoginIntent(getCurrentActivity().getApplicationContext(), CHANNEL_ID); | ||
| currentPromise = promise; | ||
| Context context= getCurrentActivity().getApplicationContext(); |
| } | ||
|
|
||
| public class GetAccessTokenTask extends AsyncTask<Void, Void, LineApiResponse<LineAccessToken>> { | ||
| final static String TAG = "GetAccessTokenTask"; |
| @@ -1,3 +1,4 @@ | |||
| <resources> | |||
| <string name="app_name">example</string> | |||
| <string name="line_channel_id">1544017747</string> | |||
There was a problem hiding this comment.
please don't push this change
| @@ -1,3 +1,4 @@ | |||
| <resources> | |||
| <string name="app_name">LineLoginManager</string> | |||
| <string name="line_channel_id">Your channel id here</string> | |||
There was a problem hiding this comment.
please add attribute translatable="false" here and bellow
Added android support using the LineAndroid SDK.