Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Application Versioning #43

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Improve Application Versioning #43

merged 2 commits into from
Oct 14, 2019

Conversation

jcscottiii
Copy link
Contributor

This will allow for better bug reports and information the binary running.
This information can be retrieved upon providing the -v or --version
flag

Closes #42

docker run --rm xmidt/petasos:local --version
petasos:
  version:      0.1.4+local
  go version:   go1.13.1
  built time:   2019-10-14 15:36:35
  git commit:   0402182
  os/arch:      linux/amd64

This will allow for better bug reports and information the binary running.
This information can be retrieved upon providing the -v or --version
flag
@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0402182). Click here to learn what that means.
The diff coverage is 30.43%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #43   +/-   ##
========================================
  Coverage          ?   8.23%           
========================================
  Files             ?       1           
  Lines             ?      85           
  Branches          ?       0           
========================================
  Hits              ?       7           
  Misses            ?      78           
  Partials          ?       0
Impacted Files Coverage Δ
main.go 8.23% <30.43%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0402182...417bf0a. Read the comment docs.

@jcscottiii jcscottiii mentioned this pull request Oct 14, 2019
@kristinapathak kristinapathak added the hacktoberfest https://comcast.github.io/hacktoberfest label Oct 14, 2019
Copy link
Member

@kcajmagic kcajmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good.

@kcajmagic kcajmagic merged commit 8458dd6 into xmidt-org:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest https://comcast.github.io/hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dynamic Versioning
4 participants