Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize makefile (#172) #173

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Optimize makefile (#172) #173

merged 2 commits into from
Oct 29, 2020

Conversation

mkocot
Copy link
Contributor

@mkocot mkocot commented Oct 2, 2020

Resolve #172 using solution from xmidt-org/talaria/pull/150

* Document docker use cases
* Optimize makefile for local testing
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #173 into main will decrease coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   73.24%   72.51%   -0.74%     
==========================================
  Files          13       13              
  Lines         527      462      -65     
==========================================
- Hits          386      335      -51     
+ Misses        127      113      -14     
  Partials       14       14              
Impacted Files Coverage Δ
stat/service.go 84.61% <0.00%> (-2.06%) ⬇️
translation/service.go 80.00% <0.00%> (-1.82%) ⬇️
hooks/hooks.go 52.70% <0.00%> (-1.62%) ⬇️
common/utils.go 59.32% <0.00%> (-1.25%) ⬇️
stat/transport.go 65.00% <0.00%> (-0.91%) ⬇️
translation/transport.go 87.69% <0.00%> (-0.51%) ⬇️
common/errors.go 100.00% <0.00%> (ø)
stat/endpoint.go 100.00% <0.00%> (ø)
common/transactor.go 100.00% <0.00%> (ø)
translation/endpoint.go 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adc8ad3...cd666fb. Read the comment docs.

@joe94
Copy link
Member

joe94 commented Oct 29, 2020

Thanks, @mkocot!

@joe94 joe94 merged commit bea2f93 into xmidt-org:main Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize makefile for local docker testing
2 participants