Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed simple header filtering #218

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Proposed simple header filtering #218

merged 2 commits into from
Jun 10, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jun 9, 2021

No description provided.

@joe94 joe94 requested a review from kristinapathak June 9, 2021 18:47
@joe94 joe94 linked an issue Jun 9, 2021 that may be closed by this pull request
Remove Authorization Header from logged headers #217
Closed
@codecov
Copy link

codecov bot commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #218 (6146423) into main (b52294b) will decrease coverage by 31.02%.
The diff coverage is 43.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #218       +/-   ##
===========================================
- Coverage   76.03%   45.00%   -31.03%     
===========================================
  Files          11       13        +2     
  Lines         388      671      +283     
===========================================
+ Hits          295      302        +7     
- Misses         87      363      +276     
  Partials        6        6
Impacted Files Coverage Δ
main.go 0.00% <ø> (ø)
basculeLogging.go 43.75% <43.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52294b...6146423. Read the comment docs.

kristinapathak
kristinapathak approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we have tests for this 🥳

@joe94 joe94 merged commit 23e1cb9 into main Jun 10, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

43.8% 43.8% Coverage
0.0% 0.0% Duplication

@joe94 joe94 deleted the bugfix/noAuthHeaderInLogs branch September 28, 2021 22:30
@kristinapathak kristinapathak mentioned this pull request Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinapathak kristinapathak kristinapathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Authorization Header from logged headers
2 participants
@joe94 @kristinapathak