Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duration for v2 endpoint if needed #266

Merged
merged 3 commits into from
Apr 20, 2022
Merged

fix duration for v2 endpoint if needed #266

merged 3 commits into from
Apr 20, 2022

Conversation

kristinapathak
Copy link
Contributor

fixes #258

@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #266 (ba87010) into main (ef82804) will decrease coverage by 3.67%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   46.47%   42.80%   -3.68%     
==========================================
  Files          12       12              
  Lines         781      848      +67     
==========================================
  Hits          363      363              
- Misses        408      475      +67     
  Partials       10       10
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
primaryHandler.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef82804...ba87010. Read the comment docs.

kcajmagic
kcajmagic approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@kcajmagic kcajmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kristinapathak kristinapathak merged commit 2cba741 into main Apr 20, 2022
@kristinapathak kristinapathak deleted the v2-endpoint-fix branch April 20, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcajmagic kcajmagic kcajmagic approved these changes

@mtrinh11 mtrinh11 mtrinh11 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2 endpoint not quite right
3 participants
@kristinapathak @kcajmagic @mtrinh11