Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped ancla, updating v3 post hook endpoint #270

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

kristinapathak
Copy link
Contributor

fixes #255

Note: the /v2 endpoint will also accept strings such as 5m.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #270 (17f146a) into main (2cba741) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

❗ Current head 17f146a differs from pull request most recent head 8bc1b80. Consider uploading reports for the commit 8bc1b80 to get more accurate results

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   42.80%   42.55%   -0.26%     
==========================================
  Files          12       12              
  Lines         848      853       +5     
==========================================
  Hits          363      363              
- Misses        475      480       +5     
  Partials       10       10              
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
primaryHandler.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cba741...8bc1b80. Read the comment docs.

@kristinapathak kristinapathak changed the title bumped wrp-go, updating v3 post hook endpoint bumped ancla, updating v3 post hook endpoint Apr 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

primaryHandler.go Show resolved Hide resolved
@kristinapathak kristinapathak merged commit 1543ee0 into main Apr 28, 2022
@kristinapathak kristinapathak deleted the webhook-registration-fix branch April 28, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration API does not honor duration attribute
3 participants