Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trace Info to WRP-Message Header #385

Merged
merged 9 commits into from
Mar 1, 2023
Merged

Conversation

renaz6
Copy link
Member

@renaz6 renaz6 commented Mar 1, 2023

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #385 (659dcfc) into main (f688f5e) will increase coverage by 0.03%.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   44.06%   44.10%   +0.03%     
==========================================
  Files          15       15              
  Lines        1121     1136      +15     
==========================================
+ Hits          494      501       +7     
- Misses        616      622       +6     
- Partials       11       13       +2     
Flag Coverage Δ
unittests 44.10% <52.94%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
translation/transport.go 82.35% <46.66%> (-2.47%) ⬇️
translation/transport_utils.go 83.33% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

translation/transport.go Outdated Show resolved Hide resolved
translation/transport.go Outdated Show resolved Hide resolved
@renaz6 renaz6 requested a review from schmidtw March 1, 2023 02:24
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides @schmidtw comment, lgtm

@renaz6 renaz6 self-assigned this Mar 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@renaz6 renaz6 merged commit c7959bd into main Mar 1, 2023
@renaz6 renaz6 deleted the AddTraceInfoToWRPMessage branch March 1, 2023 17:43
@renaz6 renaz6 mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject Tracing Information into WRP Message
3 participants