Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a large refactor of the msgpack code #107

Merged
merged 8 commits into from
Jun 10, 2021
Merged

Conversation

schmidtw
Copy link
Member

@schmidtw schmidtw commented Jun 5, 2021

This refactor is designed to improve performance (30% fewer mallocs) as
well as improve code quality and resiliance.

This refactor is designed to improve performance (30% fewer mallocs) as
well as improve code quality and resiliance.
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #107 (81ecbf2) into main (9a9e172) will increase coverage by 7.05%.
The diff coverage is 95.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   87.30%   94.35%   +7.05%     
==========================================
  Files           6        6              
  Lines        1032      886     -146     
==========================================
- Hits          901      836      -65     
+ Misses        131       50      -81     
Impacted Files Coverage Δ
src/wrp-c.c 94.20% <90.32%> (-1.43%) ⬇️
src/msgpack.c 95.60% <95.69%> (+12.61%) ⬆️
src/string.c 86.95% <0.00%> (-2.43%) ⬇️
src/utils.c 91.30% <0.00%> (-1.15%) ⬇️
src/b64.c 100.00% <0.00%> (ø)
src/locator.c 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc1c71...81ecbf2. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

87.0% 87.0% Coverage
0.0% 0.0% Duplication

@schmidtw schmidtw merged commit e6a0d12 into main Jun 10, 2021
@schmidtw schmidtw deleted the refactor-msgpack branch June 10, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant