-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relationship between DiffBuilder and JAXPXPathEngine #255
Comments
well, the If - and only if - you use something like |
The things I know so far:
For using the official xmlunit version again one solution could be to make the Or the DiffBuilder is misused at this place and a complete new solution should be found? |
If you can tell me why/where your Maybe you can provide a snippet of your code that creates and sets up the If you are using Of course it is possible you are using |
This is the class the comparison is executed:
XmlUnitInputProvider is following:
All xmlunit dependencies are resolved by custom copies of the projects.
The customization always is: The Saxon library used is:
And the class JAXPXPathEngine was changed to:
Thanks a lot for your help up to here. |
In your code I do not see any usage of any Hamcrest matcher at all, so I'm not sure how/where The I will add new overloads to |
added with a6bb601 |
the changed |
I would like to test it, but it will be a litte more complicated to use a snapshot version. I will check if I find a possibility in the company I am currently working for and give feedback during next week. Thank you for fast answers and solutions! |
I was able to test the new SNAPSHOT-version and the result was great! I passed the saxon XPathFactoryImpl to ElementSelector.byXPath(...) and a customized version of the JAXPXPathEngine:
Now it is as fast as our customized version and with the new release we are able to use xmlunit as is again :-) |
Thank you for verifying. I've just published 2.9.1. |
I have currently trouble because of very slow comparisons with the DiffBuilder class.
Changing the used xpath engine could be helpful but I am struggling with the relationship between DiffBuilder and JAXPXPathEngine.
Into the second class I can pass a custom XPathFactory (like Saxon), but I do not see a possibility to propagate this to the DiffBuilder.
Am I missing something? What is the relationship between the two classes, or is there just no relationship?
Then I would need a different approach.
Thanks for help,
I am currently a little bit confused.
The text was updated successfully, but these errors were encountered: