Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extractingText, which extracts text content of given nodes #192 #193

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

keesvandieren
Copy link

Solves #192 .

Added tests for various XML inputs.

Let me know if any adaptations are needed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.841% when pulling 8f913cf on squins:multiple-nodes-extracting-text into cf0e547 on xmlunit:main.

@keesvandieren
Copy link
Author

@bodewig I do not understand why one of the builds fails. I've looked into it, it seems that test-compilation fails because it cannot find my newly added method extractingText, but for just one build. If you can look into it and guide me if I should change anything, that would be great :-)

@bodewig
Copy link
Member

bodewig commented Jul 23, 2020

TBH I don't see the reason at first glance either. Will have to take a closer look, but it may take until the weekend before I find time to do so.

Thank you, BTW :-)

@bodewig bodewig merged commit 39534ea into xmlunit:main Jul 28, 2020
@bodewig
Copy link
Member

bodewig commented Jul 28, 2020

The compat tests passed locally, so I assume there has been some oddity in the Travis a wrong SNAPSHOT version has managed to slip into the local maven repo. We'll see what happens after the build of the main branch is through.

Many thanks!

@bodewig bodewig added this to the 2.8.0 milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants