Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics.X11.Types could include Thai etc. keybindings #64

Closed
vmchale opened this issue Apr 25, 2019 · 3 comments
Closed

Graphics.X11.Types could include Thai etc. keybindings #64

vmchale opened this issue Apr 25, 2019 · 3 comments

Comments

@vmchale
Copy link
Contributor

vmchale commented Apr 25, 2019

Looking at /usr/include/X11/keysymdef.h, there are many keys that are not mirrored in Graphics.X11.Types, e.g. the Thai keys, Hebrew Keys. It would be nice to have them.

@geekosaur
Copy link
Contributor

It's a subset, I think to work around slow compilation when they're all imported (or maybe with respect to the .hi file). Graphics.X11.ExtraTypes.XorgDefault should have the full set.

@geekosaur
Copy link
Contributor

Hm. Potentially it's just historical; the original X11 bindings were fairly sparse, which is why so much stuff is buried in "Extras" modules (which used to be a separate package). And really they don't belong in Graphics.X11.Types, they should be a distinct module. Someday the whole thing needs to be overhauled, with a flag day because everything using it will break if things are moved where they belong.

@liskin
Copy link
Member

liskin commented May 18, 2021

There are some Thai keys in Graphics.X11.ExtraTypes.XorgDefault; Graphics.X11.Types indeed seems intentionally kept minimal. There's also #21 with some scripts attached to add missing ExtraTypes keys.

@liskin liskin closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants