-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use test view and update bin folders of examples #68
Conversation
xluciano
commented
Jan 25, 2021
•
edited
Loading
edited
- lib_i2c_develop now uses Tools 15
- update the examples to use different bin folders for XS2 and XCORE-AI builds
- update license and copyrights dates as required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR mixes architecture and Product names. Naming should be
xs2 & xs3 OR x200/xCORE200 & xCORE.AI
Also to make the IF's easier to read, check for XCOREAI == 1
That is of the form:
if xcore.ai then
do xcore.ai stuff
Rather than:
if not xcore.ai
do xcore200 stuff
@mbanth here is my suggested makefile example for app_simple_single_port_master Note, it removed the XCOREAI var (uses CONFIG), fixes the arch/product naming issue and the issue with the IF. I think this scheme should be applied to the rest of the makefiles also.
|