kinda clone attrs obj argument #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -808,11 +813,12 @@ SaxLtx.prototype.end = function(data) { | |||
|
|
|||
| function unescapeXml(s) { | |||
| return s. | |||
| replace(/\&/g, '&'). | |||
There was a problem hiding this comment.
Not sure what happened here, maybe my browserify version?
|
@lloydwatkin added test and reverted unexpected browserify changes |
This was referenced Dec 3, 2014
|
ping |
|
Made some small changes, pushed as 0.8.0. Thanks! Mostly used |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #47
Ideally el.attrs would be an object with no prototype (
Object.create(null)) so we wouldn't need hasOwnProperty and iterating would be faster but that would break on IE<9.Also it's not a deep clone but we do not expect the object to be nested anyway.
So it's not perfect but I think it's better that just referencing the passed object. We can improve later.