Fix for Node.js 0.6.0: Build seems to be now in Release instead of defaul #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2011
|
Hmmm... IIRC I saw this issue during 0.5.x in another project. This fix breaks compatibility with node 0.4.x, right? A symlink would probably the wrong solution, as node is great on Windows now. ;-) |
|
I changed the patch to fix backwards compatibility (like @jorritd did it, but I used first "Release" because in future, more people will have >0.6.x as 0.4.x) |
|
+1 for mweibel's patch. That's the same code I wrote. It is 100% safe and should be merged in ASAP. |
|
I was looking for some way to generate the symlink correctly with python-waf to avoid the try/catch hack but I couldn't find a more decent solution. +1 for this patch as a workaround. |
astro
added a commit
that referenced
this pull request
Nov 17, 2011
Fix for Node.js 0.6.0: Build seems to be now in Release/ subdirectory instead of default/
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe you'll need to support backwards compatibility..