Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical bug with Minergate pool and variant 2 #813

Closed
d3c0d3d opened this issue Oct 18, 2018 · 19 comments
Closed

Critical bug with Minergate pool and variant 2 #813

d3c0d3d opened this issue Oct 18, 2018 · 19 comments
Labels

Comments

@d3c0d3d
Copy link
Contributor

d3c0d3d commented Oct 18, 2018

image

The miner is not respecting variant 2 causing rejection!

@snipeTR
Copy link

snipeTR commented Oct 18, 2018

Algo cn/2 try please

@dimkers
Copy link

dimkers commented Oct 18, 2018

./xmrig -a cryptonight-lite
or
./xmrig -a cryptonight-heavy

unable to open /home/dimkers/xmrig/build/config.json: no such file or directory
No valid configuration found. Exiting.

if ./xmrig -a cn/2
http://dl3.joxi.net/drive/2018/10/18/0025/3522/1678786/86/6c3fd65d9d.jpg

@berezinevgeniy
Copy link

if ./xmrig -a cn/2

not working -( still cn/1

@dimkers
Copy link

dimkers commented Oct 18, 2018

not working -( still cn/1

Do you mean on pool?

@berezinevgeniy
Copy link

berezinevgeniy commented Oct 18, 2018

new job from xmr.pool.minergate.com:45700 diff 1063 algo cn/1
try algo "cn/2", try "variant":2 but all new job has algo cn/1.
on original minergate gui software all working fine.

@berezinevgeniy
Copy link

any suggestions?

@dimkers
Copy link

dimkers commented Oct 18, 2018

I haven't.

@berezinevgeniy
Copy link

  • POOL 128tx exploit #1 stratum+tcp://xmr.pool.minergate.com:45700 variant 1
    why variant 1 has been choosen. variant:2 set at config.

@dimkers
Copy link

dimkers commented Oct 18, 2018

can you try on other pool(not minergate)?

@berezinevgeniy
Copy link

  • POOL 128tx exploit #1 spool.minexmr.com:4444 variant 2
    f..ck. Whats wrong with minergate ? -(

@berezinevgeniy
Copy link

problem with detection of connection`s variant maybe?

@d3c0d3d
Copy link
Contributor Author

d3c0d3d commented Oct 18, 2018

https://github.com/xmrig/xmrig/blob/master/src/common/net/Pool.cpp#L352

The bug is in this line, just change to Variant_2 and recompile the code!

@dimkers
Copy link

dimkers commented Oct 18, 2018

YES!
change in code
m_algorithm.setVariant(m_port == 45700 ? VARIANT_1 : VARIANT_0);
to
m_algorithm.setVariant(m_port == 45700 ? VARIANT_2 : VARIANT_0);
recompil and miner work!
http://joxi.ru/Y2LMN8YT9D6B9A

Thanks!

@damcko8888
Copy link

You can try with IP address instead domain name (xmr.pool.minergate.com).

https://minergate.com/blog/critical-bug-found-in-the-xmrig-miner/

@xmrig
Copy link
Owner

xmrig commented Oct 19, 2018

I will make new releases as soon as possible, right now I can't, unexpected power outage in my location. As temporary solution use IP address instead of domain name as mentioned above.
Thank you.

@xmrig
Copy link
Owner

xmrig commented Oct 19, 2018

@0xc0d32 I merge your PRs, as quick emergency fix it ok.
Thank you.

@xmrig
Copy link
Owner

xmrig commented Oct 19, 2018

Good news electricity is come back.

@d3c0d3d d3c0d3d changed the title Critical Bug in Minergate pool with variant 2 Critical Bug in Minergate pool and variant 2 Oct 19, 2018
@d3c0d3d d3c0d3d changed the title Critical Bug in Minergate pool and variant 2 Critical bug with Minergate pool and variant 2 Oct 19, 2018
@d3c0d3d
Copy link
Contributor Author

d3c0d3d commented Oct 19, 2018

Thank you! Thanks for the speed hehehe, I'll close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants