Update cn_main_loop.asm #3342
Merged
Update cn_main_loop.asm #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was scanning the code and found this line to be missing. Not sure if this was a mistake or if it was intentionally left out?
Found this line to be missing. I looked through the history and seemed like the original author of the commit missed it out.
SChernykh
approved these changes
Oct 9, 2023
|
This file is only used when compiling with Visual Studio. I guess it's not necessary to declare a symbol PUBLIC there to make it visible, because compilation didn't break. |
|
Merged into dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was scanning the code and found this line to be missing. Not sure if this was a mistake or if it was intentionally left out?