Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remote attachments #68

Merged
merged 31 commits into from
Feb 27, 2023
Merged

Implement remote attachments #68

merged 31 commits into from
Feb 27, 2023

Conversation

nakajima
Copy link
Contributor

@nakajima nakajima commented Feb 20, 2023

Implements Remote Attachments.

@nakajima nakajima marked this pull request as draft February 20, 2023 01:30
@nakajima nakajima changed the title Add proposal for remote attachments Implement remote attachments Feb 24, 2023
@nakajima nakajima marked this pull request as ready for review February 24, 2023 23:39
Copy link
Contributor

@elisealix22 elisealix22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible to see this land.

Also /cc @nplasterer since we'll likely want this in the Android SDK as well! 👀

We were setting the timestamp of the encoded message but not the envelope
@nakajima nakajima merged commit 71316ac into main Feb 27, 2023
@nakajima nakajima deleted the remote-attachment-proposal branch February 27, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants