be:spdk: process spdk events before reusing controller

[LiadOz]

Signed-off-by: Liad Oz liadozil@gmail.com

[LiadOz]

resolves #109

[safl]

Hi @LiadOz,
LGTM, CI is spinning up to check for any regressions.
Thanks,
Simon

[safl]

Looks like the test xnvme_tests_enum open --count 4 fails with this change.
The test is here tests/enum.c. In the failing scenario it attempts to open the same PCIe address multiple times, this is the use-case the cref was made for, as we cannot have multiple driver instances, we have to share and re-use the one we have previously attached to. I am currently traveling, so can't dive into the code, however @birkelund and @Baekalfen did you see a similar thing / issues when references counting in #111 ? Something that might be applicable here?

[birkelund]

Looks like the test xnvme_tests_enum open --count 4 fails with this change. The test is here tests/enum.c. In the failing scenario it attempts to open the same PCIe address multiple times, this is the use-case the cref was made for, as we cannot have multiple driver instances, we have to share and re-use the one we have previously attached to. I am currently traveling, so can't dive into the code, however @birkelund and @Baekalfen did you see a similar thing / issues when references counting in #111 ? Something that might be applicable here?

Test is OK for the be-vfio backend.

[LiadOz]

Is there a way to see the logs for this test? I suspect the controller might be detached when using it similar to #107, before this change assuming the controller was detached it gets to spdk_nvme_ctrlr_get_ns which returns 0 and then creates a new controller.

[karlowich]

LGTM!

[safl]

@LiadOz this is looking great thank you. Can you redo this as a rebase to avoid the merge-commit?

[safl]

Great, thanks!