Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch docker-images #202

Merged
merged 1 commit into from
Nov 10, 2022
Merged

ci: switch docker-images #202

merged 1 commit into from
Nov 10, 2022

Conversation

safl
Copy link
Member

@safl safl commented Nov 9, 2022

The 'build-linux' job uses docker-images to test the build on various
Linux distributions. After the container is initialized, then the xNVMe
dependencies are installed via the respective script in the toolbox,
e.g. 'toolbox/pkgs/debian-bullseye.sh'.

This takes about 1-18minutes to finish depending on the distribution.
Every so often, the task fails as distro-repositories timeout etc.

To remove that task from the CI, thus reduce time and the occasional
failure, then docker-images with the dependencies pre-baked are used
instead. These images are produced by
https://github.com/xnvme/xnvme-docker, and also provided as "packages"
on that repository, retrivable via ghcr.io.

The 'build-linux' job uses docker-images to test the build on various
Linux distributions. After the container is initialized, then the xNVMe
dependencies are installed via the respective script in the toolbox,
e.g. 'toolbox/pkgs/debian-bullseye.sh'.

This takes about 1-18minutes to finish depending on the distribution.
Every so often, the task fails as distro-repositories timeout etc.

To remove that task from the CI, thus reduce time and the occasional
failure, then docker-images with the dependencies pre-baked are used
instead. These images are produced by
https://github.com/xnvme/xnvme-docker, and also provided as "packages"
on that repository, retrivable via ghcr.io.

Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
@safl safl marked this pull request as ready for review November 10, 2022 12:26
@safl safl added the pr-ready-for-test PR is ready for functional tests label Nov 10, 2022
@safl safl mentioned this pull request Nov 10, 2022
16 tasks
Copy link
Contributor

@karlowich karlowich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent!

@safl safl merged commit 8e0c5ac into xnvme:next Nov 10, 2022
@safl safl mentioned this pull request Nov 10, 2022
49 tasks
@safl safl added this to the v0.7.0 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-ready-for-test PR is ready for functional tests
Development

Successfully merging this pull request may close these issues.

2 participants