Preparing for release of v0.3.0 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following hooks are removed from the pre-commit-framework: * git-commit-message, it did not reflect the commit-message format correctly, it has only been commented out as it should be adjusted and re-introduced * vultr and mypy, the things that they are good for does not apply to the use of Python in the toolbox, thus they produce a lot of false-positives to work around / add exceptions to, and not catching anything useful. Should the nature of the Python code change, then we can add them again and set them up properly * pylint, with flake8 also present, then the two in some cases disagree on linting. pylint is quite pedantic, flake8 is slighty more pragmatic. This can also be seen in the amount of exceptions added to the pylint hook before removal. flake8 will take over the linting duties for now. Additonally, a redundant comment was removed from the Shellcheck hook Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
Signed-off-by: Simon A. F. Lund <simon.lund@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the routine tasks of updating:
Changes after this are expected to only be fixes and documentation.