Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in the transpilation: wrong output pin labels #1204

Merged
merged 1 commit into from
May 15, 2018
Merged

Fix bug in the transpilation: wrong output pin labels #1204

merged 1 commit into from
May 15, 2018

Conversation

brusherru
Copy link
Contributor

There is no issue. But it's a critical bug 😬

If you make some Node that have few unnamed output ports — it will fail in C++ compilation, cause linked Nodes points to not normalized pin label (output_OUT instead of output_OUT1, output_OUT2 and so on).

@brusherru brusherru self-assigned this May 10, 2018
@brusherru brusherru requested a review from a team May 10, 2018 17:43
evgenykochetkov
evgenykochetkov approved these changes May 10, 2018
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

packages/xod-arduino/src/transpiler.js Outdated
),
R.chain(Project.getPinByKey(pinKey)),
R.chain(Project.getPatchByNode(R.__, project)),
R.chain(R.compose(Maybe, R.prop(pinKey))),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we now have maybeProp for this in xod-func-tools

nkrkv
nkrkv approved these changes May 11, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

And please, use maybeProp

@brusherru brusherru force-pushed the fix-transpiler-wrong-output-pinlabels branch 4 times, most recently from f628bb8 to 271e2ec Compare May 14, 2018 13:40
@brusherru brusherru changed the base branch from master to fix-1200-sort-attachments May 14, 2018 13:41
@brusherru brusherru force-pushed the fix-transpiler-wrong-output-pinlabels branch from 271e2ec to d3e9485 Compare May 14, 2018 14:17
@brusherru brusherru changed the base branch from fix-1200-sort-attachments to master May 15, 2018 10:28
@brusherru brusherru merged commit a99a5dd into master May 15, 2018
@brusherru brusherru deleted the fix-transpiler-wrong-output-pinlabels branch May 15, 2018 10:28
@nkrkv nkrkv mentioned this pull request May 22, 2018
Merged
@nkrkv nkrkv added the hotfix Issue/PR for a patch release label May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

Assignees

@brusherru brusherru

Labels
hotfix Issue/PR for a patch release t:bug urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brusherru @nkrkv @evgenykochetkov