Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bound value migration for pulses #1207

Merged
merged 1 commit into from
May 14, 2018

Conversation

brusherru
Copy link
Contributor

There is no issue.
Some old bound values ("false" on pulses) was not converted into new literal "Never". This PR fixes it.
It's a part (1/2) of critical bug reported on the forum.

The second half of the problem is about new bundled xod/core and old xod/core saved in the user-workspace/__libs__ folder.

@brusherru brusherru self-assigned this May 14, 2018
@brusherru brusherru requested a review from a team May 14, 2018 11:18
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brusherru brusherru merged commit 91bfcf3 into master May 14, 2018
@brusherru brusherru deleted the fix-literal-migration-for-pulses branch May 14, 2018 12:32
@nkrkv nkrkv added the hotfix Issue/PR for a patch release label May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Issue/PR for a patch release s:core t:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants