Extract I2C-related nodes of standard library to xod/i2c
#1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "x": 136, | ||
| "y": 0 | ||
| }, | ||
| "type": "xod/patch-nodes/input-byte" |
There was a problem hiding this comment.
Is there a reason this is an input-byte besides https://github.com/arduino/ArduinoCore-avr/blob/b7c607663fecc232e598f2c0acf419ceb0b7078c/libraries/Wire/src/Wire.h#L61-L63 ?
IMHO, "Number of bytes to request" should be a number.
There was a problem hiding this comment.
Oops, no. Good catch. Should be a number, I will fix it
nkrkv
force-pushed
the
refactor-1253-extract-i2c-nodes
branch
from
00f1c2c
to
0f64bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1253