Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use port and byte pins in common hardware #1274

Merged
merged 2 commits into from
Jun 9, 2018
Merged

Use port and byte pins in common hardware #1274

merged 2 commits into from
Jun 9, 2018

Conversation

evgenykochetkov
Copy link
Contributor

Closes #1254

@evgenykochetkov evgenykochetkov self-assigned this Jun 8, 2018
@evgenykochetkov
Copy link
Contributor Author

Also, @brusherru suggested yesterday to mark hc-sr04-ultrasonic-time an an utility. WDYT?

@nkrkv
Copy link
Member

nkrkv commented Jun 8, 2018

@evgenykochetkov I think we should keep the common-hardware public API as is for now. It sounds OK, but let’s think again very soon when we’ll split the library into many xod-dev/lalala libs.

nkrkv
nkrkv requested changes Jun 8, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Suggest changing bound defaults to sensible values:

  • If a hardware piece is analog, bind A0 as default, not D0
  • If it has an ADDR, bind a hexadecimal value to it

@nkrkv nkrkv mentioned this pull request Jun 8, 2018
Merged
@evgenykochetkov evgenykochetkov force-pushed the refactor-1254-use-port-and-byte-pins-in-common-hardware branch from 24390b8 to fa3525a Compare June 8, 2018 16:24
nkrkv
nkrkv approved these changes Jun 9, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evgenykochetkov evgenykochetkov force-pushed the refactor-1254-use-port-and-byte-pins-in-common-hardware branch from fa3525a to 922e913 Compare June 9, 2018 09:19
@evgenykochetkov evgenykochetkov force-pushed the refactor-1254-use-port-and-byte-pins-in-common-hardware branch from 922e913 to deab64b Compare June 9, 2018 13:56
@evgenykochetkov evgenykochetkov merged commit b28e23e into master Jun 9, 2018
@evgenykochetkov evgenykochetkov deleted the refactor-1254-use-port-and-byte-pins-in-common-hardware branch June 10, 2018 07:12
This was referenced Jan 18, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@brusherru brusherru brusherru approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykochetkov @nkrkv @brusherru