Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toggle items into View menu #1340

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Add toggle items into View menu #1340

merged 1 commit into from
Jul 9, 2018

Conversation

brusherru
Copy link
Contributor

It closes #1292.

@brusherru
tweak(xod-client, xod-client-browser, xod-client-electron): add "Togg…
8c9af1a 
…le Project Browser" and "Toggle Inspector" into "View" menu
@brusherru brusherru self-assigned this Jul 9, 2018
@brusherru brusherru requested a review from a team July 9, 2018 11:00
@brusherru
Copy link
Contributor Author

brusherru commented Jul 9, 2018 •
edited
Loading

@nkrkv @evgenykochetkov should I add hotkeys?
i for Inspector, p for Project Browser?

evgenykochetkov
evgenykochetkov approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evgenykochetkov
Copy link
Contributor

evgenykochetkov commented Jul 9, 2018 •
edited
Loading

i is already taken, but yes, that would be nice IMO

@brusherru
Copy link
Contributor Author

Ctrl+I and Ctrl+P? 🤔

@brusherru brusherru merged commit be0af0d into master Jul 9, 2018
@brusherru brusherru deleted the tweak-1292-toggle-items-in-view-menu branch July 9, 2018 15:07
@nkrkv nkrkv mentioned this pull request Jul 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

Assignees

@brusherru brusherru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Project Browser and Inspector toggling to View menu
2 participants
@brusherru @evgenykochetkov