Make possible to upgrade packages within IDE #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
requested changes
Oct 15, 2018
There was a problem hiding this comment.
Suggest fixing the terminology in user messages and JS symbol names. When we download and install, it is an upgrade. When we check, we are checking for updates. That is, upgrade is an action: desctructive and not undoable; update is informational it is a noun.
|
|
||
| renderCores() { | ||
| if (!this.state.cores) { | ||
| return <span>Checking for updates. Please wait...</span>; |
|
|
||
| return ( | ||
| <div> | ||
| <p>There are some packages you can update:</p> |
| @@ -0,0 +1,3 @@ | |||
| export const SHOW_UPDATE_ARDUPACKAGES_POPUP = 'SHOW_UPDATE_ARDUPACKAGES_POPUP'; | |||
| export const HIDE_UPDATE_ARDUPACKAGES_POPUP = 'HIDE_UPDATE_ARDUPACKAGES_POPUP'; | |||
| export const RUN_UPDATE_PROCESS = 'RUN_UPDATE_PROCESS'; | |||
There was a problem hiding this comment.
Eh... Flux misuse. Actions are facts, not intents. That is:
ARDUPACKAGES_UPDATE_REQUESTED— it is our decision should any dialog be shown or two, or the upgrade should start right awayPOPUP_DISCARDED— it does not matter which popup, its identifier might be included in the payload in a unified way. The fact is just about clicking the cross icon, “Cancel” button, or ESC keyARDUPACKAGES_UPGRADE_PROCEED— the reaction is the same, but semantics is better
There was a problem hiding this comment.
After googling again for Redux action name conventions, I think the best one to stick to is <NOUN>_<VERB_INFINITIVE>. That is:
ARDUPACKAGES_UPDATE_REQUESTPOPUP_DISCARDorPOPUP_CLOSEARDUPACKAGES_UPGRADE_PROCEED
See
nkrkv
requested changes
Oct 15, 2018
| @@ -106,6 +106,9 @@ const rawItems = { | |||
| uploadToArduino: { | |||
| label: 'Upload to Arduino...', | |||
| }, | |||
| updatePackages: { | |||
| label: 'Update Packages...', | |||
There was a problem hiding this comment.
Upgrade Arduino Packages & Toolchains...
brusherru
force-pushed
the
feat-1453-upgrade-packages
branch
2 times, most recently
from
f3ac38a
to
8f199ab
Compare
|
@nkrkv fixed but just rename |
nkrkv
requested changes
Oct 15, 2018
| * | ||
| * :: (Object -> _) -> ArduinoCli -> Promise String Error | ||
| */ | ||
| const updateArduinoPackages = (onProgress, cli) => cli.core.upgrade(onProgress); |
| subscribeIpc(() => checkUpdates(cli), CHECK_ARDUINO_DEPENDENCY_UPDATES); | ||
| }; | ||
|
|
||
| export const subscribeUpdateArduinoPackages = cli => { |
| client.deleteProcess(processId, client.INSTALL_ARDUINO_DEPENDENCIES) | ||
| ); | ||
| export const showUpdatePackagesPopup = () => ({ | ||
| type: AT.ARDUPACKAGES_UPDATE_REQUESTED, |
There was a problem hiding this comment.
Name after action type:
updateArdupackages or updatePackages
| type: AT.ARDUPACKAGES_UPDATE_REQUESTED, | ||
| }); | ||
| export const hideUpdatePackagesPopup = () => ({ | ||
| type: AT.UPDATE_ARDUPACKAGES_POPUP_CLOSED, |
brusherru
force-pushed
the
feat-1453-upgrade-packages
branch
from
8f199ab
to
5fb951f
Compare
evgenykochetkov
approved these changes
Oct 15, 2018
| @@ -41,3 +41,37 @@ export const deleteProcess = (id, type) => ({ | |||
| payload: { id }, | |||
| meta: { status: STATUS.DELETED }, | |||
| }); | |||
|
|
|||
| export const createProcess = type => dispatch => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #1453.