Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make proper errors for different steps of upload process #1484

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Make proper errors for different steps of upload process #1484

merged 1 commit into from
Oct 18, 2018

Conversation

brusherru
Copy link
Contributor

It fixes #1478

@brusherru brusherru self-assigned this Oct 18, 2018
@brusherru brusherru requested a review from a team October 18, 2018 16:22
nkrkv
nkrkv reviewed Oct 18, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, target toward 0.25.x

@brusherru brusherru changed the base branch from master to 0.25.x October 18, 2018 16:25
evgenykochetkov
evgenykochetkov approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nkrkv
nkrkv requested changes Oct 18, 2018
View reviewed changes
packages/xod-client-electron/src/app/arduinoCli.js Outdated
// =============================================================================

// :: Error -> RejectedPromise Error
const catchCompileError = err =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are error wrappers and should have names like wrapCompileError. Otherwise, they look misleading when used. One can think they recover from errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

nkrkv
nkrkv approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nkrkv
nkrkv requested changes Oct 18, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I suggested to remove the title, but I missed the effect of the color. Now I’m thinking the title in the red area is required.

BTW, let’s test the new GitHub suggestions feature ;)

packages/xod-client-electron/src/upload/messages.js Show resolved Hide resolved
@brusherru brusherru merged commit f22b260 into 0.25.x Oct 18, 2018
@brusherru brusherru deleted the fix-1478-misleading-errors branch October 18, 2018 17:39
@evgenykochetkov evgenykochetkov added the hotfix Issue/PR for a patch release label Oct 19, 2018
@brusherru brusherru mentioned this pull request Oct 19, 2018
Merged
This was referenced Oct 19, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

Assignees

@brusherru brusherru

Labels
hotfix Issue/PR for a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brusherru @nkrkv @evgenykochetkov