Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make xod/core/clock tick even if EN is always dirty #1496

Merged

Conversation

evgenykochetkov
Copy link
Contributor

In patches like this
screen shot 2018-10-22 at 20 19 27
clock would never start because EN is always dirty.

clock-err.xodball.zip

@evgenykochetkov evgenykochetkov self-assigned this Oct 22, 2018
@evgenykochetkov evgenykochetkov force-pushed the fix-stdlib-clock-never-ticks-with-dirty-en-pin branch 2 times, most recently from 4e8474e to 4c49ac5 Compare October 23, 2018 09:14
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 But this changeset changes semantics as well. Previously, clock will never emit a tick in the same transaction it receives a pulse on RST. Now it is no longer true.

IMO what actually should be done is comparing the current EN value with one from the previous evaluate instead of checking isInputDirty. BTW, guaranteeing continuous functional values would fix this automatically, however, I understand we can’t wait so long.

Any ideas? Fix as is or change the behavior?

@nkrkv nkrkv added the wip label Oct 24, 2018
@evgenykochetkov evgenykochetkov force-pushed the fix-stdlib-clock-never-ticks-with-dirty-en-pin branch from 4c49ac5 to 1a83cac Compare November 1, 2018 13:48
@evgenykochetkov evgenykochetkov changed the base branch from master to 0.25.x November 1, 2018 13:49
@evgenykochetkov evgenykochetkov force-pushed the fix-stdlib-clock-never-ticks-with-dirty-en-pin branch from 1a83cac to d54baeb Compare November 1, 2018 13:50
@evgenykochetkov
Copy link
Contributor Author

Tweaked the implementation so that original behavior of RST is preserved

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evgenykochetkov evgenykochetkov merged commit 90a7342 into 0.25.x Nov 1, 2018
@evgenykochetkov evgenykochetkov deleted the fix-stdlib-clock-never-ticks-with-dirty-en-pin branch November 1, 2018 15:52
@nkrkv nkrkv added the hotfix Issue/PR for a patch release label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Issue/PR for a patch release s:stdlib t:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants