-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make xod/core/clock tick even if EN is always dirty #1496
Make xod/core/clock tick even if EN is always dirty #1496
Conversation
4e8474e
to
4c49ac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 But this changeset changes semantics as well. Previously, clock
will never emit a tick in the same transaction it receives a pulse on RST
. Now it is no longer true.
IMO what actually should be done is comparing the current EN
value with one from the previous evaluate
instead of checking isInputDirty
. BTW, guaranteeing continuous functional values would fix this automatically, however, I understand we can’t wait so long.
Any ideas? Fix as is or change the behavior?
4c49ac5
to
1a83cac
Compare
1a83cac
to
d54baeb
Compare
Tweaked the implementation so that original behavior of RST is preserved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
In patches like this
clock
would never start becauseEN
is always dirty.clock-err.xodball.zip