Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xod/bits/shift-* works with int32_t #1524

Merged
merged 1 commit into from
Nov 2, 2018
Merged

xod/bits/shift-* works with int32_t #1524

merged 1 commit into from
Nov 2, 2018

Conversation

brusherru
Copy link
Contributor

It fixes #1510

@brusherru brusherru added the hotfix Issue/PR for a patch release label Nov 1, 2018
@brusherru brusherru self-assigned this Nov 1, 2018
@brusherru brusherru requested a review from a team November 1, 2018 16:06
@brusherru brusherru changed the base branch from master to 0.25.x November 1, 2018 16:06
@brusherru brusherru changed the title Make xod/bits shifts work with int32_t xod/bits/shift-* works with int32_t Nov 1, 2018
nkrkv
nkrkv approved these changes Nov 2, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brusherru brusherru merged commit 6d581aa into 0.25.x Nov 2, 2018
@brusherru brusherru deleted the fix-1510-shift-bits branch November 2, 2018 14:28
@nkrkv nkrkv mentioned this pull request Nov 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenykochetkov evgenykochetkov evgenykochetkov left review comments

@nkrkv nkrkv nkrkv approved these changes

Assignees

@brusherru brusherru

Labels
hotfix Issue/PR for a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brusherru @nkrkv @evgenykochetkov