Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Select All" hotkey in Desktop IDE #1554

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Fix "Select All" hotkey in Desktop IDE #1554

merged 1 commit into from
Nov 21, 2018

Conversation

brusherru
Copy link
Contributor

It fixes #1552

@brusherru brusherru self-assigned this Nov 19, 2018
@brusherru brusherru requested a review from a team November 19, 2018 12:51
evgenykochetkov
evgenykochetkov approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think this should be merged to 0.25.x branch

@brusherru brusherru force-pushed the fix-1552-desktop-select-all-hotkey branch from de17cf5 to 99035c9 Compare November 19, 2018 16:21
@brusherru brusherru changed the base branch from master to 0.25.x November 19, 2018 16:21
@evgenykochetkov evgenykochetkov mentioned this pull request Nov 20, 2018
Merged
@brusherru brusherru force-pushed the fix-1552-desktop-select-all-hotkey branch from 99035c9 to 8008815 Compare November 21, 2018 11:30
@brusherru brusherru merged commit 0e598a0 into 0.25.x Nov 21, 2018
@brusherru brusherru deleted the fix-1552-desktop-select-all-hotkey branch November 21, 2018 13:12
This was referenced Nov 22, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

Assignees

@brusherru brusherru

Labels
s:client t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brusherru @nkrkv @evgenykochetkov