-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xod/core/integrate-dt
#1590
Conversation
335938d
to
f04b39b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I’m voting for inclusion. However, we need a comprehensive tabtest first
+1 for tabtests and inclusion :) |
+1 for an integration. Today I was looking for such a node. |
Me too. Nevertheless, all hardware-independent nodes going to the standard library must be covered with tests. Ok, this PR looks abandoned (@gabbapeople is very busy working on a YouTube project), who can help with tabtests? @evgenykochetkov ? |
f04b39b
to
c38388a
Compare
4560bd2
to
00721a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Kinda very useful node to the
xod/core
library.Gonna use it a second time in my projects.
I'm sure that XOD should support it.
What do you think?