Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xod/core/integrate-dt #1590

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Conversation

gabbapeople
Copy link
Contributor

@gabbapeople gabbapeople commented Dec 13, 2018

Kinda very useful node to the xod/core library.

Gonna use it a second time in my projects.
I'm sure that XOD should support it.
What do you think?

@gabbapeople gabbapeople requested a review from a team December 13, 2018 15:30
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I’m voting for inclusion. However, we need a comprehensive tabtest first

@brusherru
Copy link
Contributor

+1 for tabtests and inclusion :)

@donovaly
Copy link

+1 for an integration. Today I was looking for such a node.

@nkrkv
Copy link
Member

nkrkv commented Feb 27, 2019

Me too. Nevertheless, all hardware-independent nodes going to the standard library must be covered with tests.

Ok, this PR looks abandoned (@gabbapeople is very busy working on a YouTube project), who can help with tabtests? @evgenykochetkov ?

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@evgenykochetkov evgenykochetkov merged commit 8f844eb into master Feb 27, 2019
@evgenykochetkov evgenykochetkov deleted the feat-xod-core-integrate-dt branch February 27, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants